-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Fori loop simple case without hard-code #7031
[test] Fori loop simple case without hard-code #7031
Conversation
// runtime::ComputationClient::ComputationPtr computation; | ||
// }; | ||
// std::vector<runtime::ComputationClient::ComputationPtr> | ||
runtime::ComputationClient::ComputationPtr GetXLAComputation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @miladm, this is the script code for post-order tracing compile function
// Compile(*tensors, devices, coll, &po_data, ir_values).computation) | ||
XLAGraphExecutor::saveComputation* compile_result = Compile(*tensors, devices, coll, &po_data, ir_values).computation | ||
return compile_result | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @miladm, this is the script code implementation for post-order tracing compile function
I have
which works on CPU device but error out for XLA devices. Let's try to get this simple example working. |
test/test_test_fori_loop.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script used for compare order of upper/lower for post-order
thanks, based on this PR, created and updated to simple test case in #7094, would close this pr for now |
code based on #7012, create post-order tracing interface on python level, to enable post-order tracing for XLAComputation like https://github.com/pytorch/xla/blob/master/torch_xla/csrc/xla_graph_executor.cpp#L1293