Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update spmd.md for doc #7019

Merged
merged 2 commits into from
May 30, 2024
Merged

[Doc] Update spmd.md for doc #7019

merged 2 commits into from
May 30, 2024

Conversation

ManfeiBai
Copy link
Collaborator

@ManfeiBai ManfeiBai commented May 2, 2024

Compared format style, we might want to add one blank line after the line end with :

@ManfeiBai ManfeiBai marked this pull request as ready for review May 2, 2024 19:12
@lsy323
Copy link
Collaborator

lsy323 commented May 6, 2024

Hi @ManfeiBai, I checked the html file from the CI job, looks like there is another newline missing at https://github.com/pytorch/xla/blob/master/docs/spmd.md?plain=1#L506. Could you please help correct it in this PR as well? Let's land after verifying the generated html looks good. Thanks for working on it!

@ManfeiBai
Copy link
Collaborator Author

Hi @ManfeiBai, I checked the html file from the CI job, looks like there is another newline missing at https://github.com/pytorch/xla/blob/master/docs/spmd.md?plain=1#L506. Could you please help correct it in this PR as well? Let's land after verifying the generated html looks good. Thanks for working on it!

Hi, @lsy323, sure, updated

@ManfeiBai ManfeiBai merged commit cb482bc into master May 30, 2024
20 checks passed
lsy323 pushed a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants