-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support torch_xla2 benchmarking using torchbench #7013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
reviewed
May 2, 2024
vanbasten23
reviewed
May 2, 2024
vanbasten23
reviewed
May 2, 2024
ysiraichi
reviewed
May 6, 2024
qihqi
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrate the torch_xla2 testing into the benchmarking.
Details
The PR ports the torch_xla2 running script based on file here into the existing benchmark script.
How to run
To run the torch_xla2 benchmarking, you need to install the torch_xla2 based on instructions experimental/torch_xla2/README.md
Currently torch_xla2 doesn't work with dynamo. We need to append flag
--torch-xla2
to switch to torch_xla2, e.g.,In practical, we need to make sure JAX version and torch_xla are using the same PJRT version. I did the openxla pin update (backport) for torch_xla in order to use PJRT
0.47
verison.Sample result
Just tried a simple model
dcgan
on TPU v5p-8, the torch_xla2 performance is impressive: