Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework docs push #6954

Merged
merged 11 commits into from
Apr 29, 2024
Merged

Rework docs push #6954

merged 11 commits into from
Apr 29, 2024

Conversation

will-cromar
Copy link
Collaborator

@will-cromar will-cromar commented Apr 23, 2024

  • Follow current GHA examples for deploying pages.
  • Tweak logic for selecting subdir. As near as I can tell, every release commit was updating master's docs:
    if [[ "$BRANCH_NAME" == release/* ]]; then
    SUBDIR_NAME=$BRANCH_NAME
    else
    SUBDIR_NAME="master"
    fi
  • Use token from GHA instead of bot account. Nope, org policy forbids us from getting a GHA token with write access
  • Run docs build for every event, but only publish for pushes. You can check what the generated docs will look like in the github-pages artifact (releases/$PR_NUMBER/merge)

@will-cromar will-cromar requested a review from JackCaoG April 26, 2024 22:54
@will-cromar will-cromar changed the title [WIP] Rework docs push Rework docs push Apr 26, 2024
@will-cromar will-cromar added the DO_NOT_MERGE_YET For PRs which cannot be merged, despite tests passing label Apr 26, 2024
@will-cromar
Copy link
Collaborator Author

The nested job 'deploy' is requesting 'pages: write, id-token: write', but is only allowed 'pages: none, id-token: none'.

Hmmm, there may be a repository setting we need to change.

@will-cromar will-cromar removed the request for review from JackCaoG April 26, 2024 22:59
@will-cromar will-cromar removed the DO_NOT_MERGE_YET For PRs which cannot be merged, despite tests passing label Apr 29, 2024
@will-cromar will-cromar requested a review from JackCaoG April 29, 2024 18:52
@will-cromar will-cromar marked this pull request as ready for review April 29, 2024 18:52
@will-cromar will-cromar merged commit c91171d into master Apr 29, 2024
21 of 22 checks passed
will-cromar added a commit that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants