Build CPP tests in new CI workflow #6947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-cromar
changed the title
will-cromar
requested review from
JackCaoG,
yeounoh,
mateuszlewko and
stgpetrovic
as code owners
will-cromar
force-pushed
the
wcromar/cpp-tests
branch
from
acf0586 to
d3c9c38
Compare
JackCaoG
reviewed
Apr 26, 2024
JackCaoG
reviewed
Apr 26, 2024
Comment on lines
+24
to
+38
| // Placeholder plugin for testing only. Does not implement multiprocessing or | ||
| // configuration. Very likely will not work from Python code. | ||
| class LibraryPlugin : public PjRtPlugin { | ||
| public: | ||
| std::string library_path() const override { | ||
| return sys_util::GetEnvString("PJRT_LIBRARY_PATH", ""); | ||
| } | ||
|
|
||
| const std::unordered_map<std::string, xla::PjRtValueType> | ||
| client_create_options() const override { | ||
| return {}; | ||
| } | ||
|
|
||
| bool requires_xla_coordinator() const override { return false; } | ||
| }; |
There was a problem hiding this comment.
why do we need this plugin?
There was a problem hiding this comment.
This is just a minimal implementation of the plugin interface that lets us pass in a path. We want to take this codepath during init, rather than the statically linked CUDA client:
Normally the plugin registration is done through Python, so we need a workaround for the C++ tests.
JackCaoG
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch_xlapackage and the C++ tests, this invalidates the cache. Rather than trying to bringtest/cpp/run_test.shin line withsetup.py, we can just build everything at oncetest_suitefor CPP testsA typical run in the old CI took about 2.5 hours. This test run took only 1 hour and 10 minutes. Most tests in the new workflow finish before the old build finishes, e.g.