Add a DynamoSyncInputExecuteTime counter
#6813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonjoolee95
reviewed
Mar 25, 2024
test/dynamo/test_dynamo.py
Outdated
| @@ -124,6 +124,7 @@ def test_simple_model(self): | |||
| xla_y3 = xla_y * 3 | |||
| res_xla_dynamo_3 = fn_simple_dynamo(xla_xy, xla_y3) | |||
| res_cpu_3 = self.fn_simple(x + y, y * 3) | |||
| breakpoint() | |||
|
LGTM, the |
|
Let me rebase this pr |
JackCaoG
force-pushed
the
JackCao/Dynamo_sync_input_counter
branch
from
748e713 to
e3a7c37
Compare
|
opps, @wonjoolee95 do you mind stamping this pr? |
wonjoolee95
approved these changes
Apr 1, 2024
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Oct 11, 2024
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Dec 11, 2024
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aot-autograd might apply reshape on the input before passing to
openxlabackend, in that case we need to execute to sync the input. Add a counter to track that.