Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XLA pin #6797

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Update XLA pin #6797

merged 1 commit into from
Mar 22, 2024

Conversation

yeounoh
Copy link
Contributor

@yeounoh yeounoh commented Mar 21, 2024

Update XLA pin to b9ece5154181608ff1acea9b02a1ee7a526af16b to incorporate auto-sharding patch.

@yeounoh yeounoh requested a review from lsy323 March 21, 2024 16:46
@yeounoh yeounoh self-assigned this Mar 21, 2024
@yeounoh yeounoh force-pushed the move_pin_for_auto branch from ac0e5eb to a4452ce Compare March 22, 2024 16:01
@yeounoh
Copy link
Contributor Author

yeounoh commented Mar 22, 2024

Local build succeeded, ResNet number looks good

| Training Device=xla:0/3 Epoch=1 Step=600 Loss=0.00287 Rate=1767.51 GlobalRate=612.32 Time=16:12:17
| Training Device=xla:0/1 Epoch=1 Step=600 Loss=0.00287 Rate=1767.52 GlobalRate=604.49 Time=16:12:17
| Training Device=xla:0/2 Epoch=1 Step=600 Loss=0.00287 Rate=1767.34 GlobalRate=620.80 Time=16:12:17
| Training Device=xla:0/0 Epoch=1 Step=620 Loss=0.00274 Rate=1767.76 GlobalRate=619.21 Time=16:12:18
| Training Device=xla:0/2 Epoch=1 Step=620 Loss=0.00274 Rate=1767.80 GlobalRate=634.05 Time=16:12:18
| Training Device=xla:0/3 Epoch=1 Step=620 Loss=0.00274 Rate=1767.57 GlobalRate=625.48 Time=16:12:18
| Training Device=xla:0/1 Epoch=1 Step=620 Loss=0.00274 Rate=1767.57 GlobalRate=617.58 Time=16:12:18

lsy323
lsy323 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@lsy323 lsy323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Pending on CI

@ghpvnist ghpvnist self-requested a review March 22, 2024 17:45
ghpvnist
ghpvnist approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@ghpvnist ghpvnist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for waiting for my changes to land. Could you also update the PR description hash?

@yeounoh yeounoh merged commit b0ceb2b into master Mar 22, 2024
20 checks passed
yeounoh added a commit that referenced this pull request Mar 22, 2024
@yeounoh
Update XLA pin (#6797)
959a349
This was referenced Mar 22, 2024
Merged
Closed
@vanbasten23 vanbasten23 mentioned this pull request Mar 25, 2024
Closed
lsy323 pushed a commit that referenced this pull request Mar 25, 2024
@yeounoh
[r2.3] Update XLA pin (#6797) (#6811)
7e8b8fb
@JackCaoG JackCaoG mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackCaoG JackCaoG JackCaoG approved these changes

@ghpvnist ghpvnist ghpvnist approved these changes

@lsy323 lsy323 lsy323 approved these changes

Assignees

@yeounoh yeounoh

Labels
backport_2.3 openxla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yeounoh @lsy323 @ghpvnist @JackCaoG