Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR makes all necessary changes to support Pallas's FlashAttention.
The major change here is to disable TPU layout that places bigger dimensions on most minor layout locations. This optimization boosts performance for dim > 2 tensor input applications, like resnet. For LLM, it should be fine to disable since all inputs are 2D.
ResNet:
python test/test_train_mp_imagenet.py --fake_data --model=resnet50 --num_epochs=1 --metrics_debug
XLA_TPU_LAYOUT = 0
XLA_TPU_LAYOUT = 1
Llama 2 2B
XLA_TPU_LAYOUT = 0
XLA_TPU_LAYOUT = 1
Test Plan:
python test/test_operations.py -v -k test_tpu_custom_call_pallas_flash_attention