-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[benchmarks] Small fixes for benchmarking script. #6632
Conversation
Thanks, I think you forgot to import |
There are also other issues I see in recent check-ins: xla/benchmarks/torchbench_model.py Line 309 in 0a2e5b5
self.model_name .For the batch_size , I can't find DEFAULT_EVAL_BSIZE and DEFAULT_TRAIN_BSIZE to be use anywhere.
|
find_near_file
function.
@zpcore @vanbasten23 @cota I have updated this PR fixing another small issues with the benchmarking script, as pointed out by @zpcore. I have also tested it by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixing!
Hi @ysiraichi , do you know where the default batch size from torchbench was used in the code? |
Do you mean where do we set the default batch size? As far as I understand, torchbench does it automatically when we instantiate a xla/benchmarks/torchbench_model.py Lines 329 to 333 in 4cde625
Which ends up in this function. |
Got it, thanks! Now the batch_size setting looks clear to me. |
This PR implements small fixes introduced by past PRs:
self
argument from thefind_near_file
function that was left-over in the last PR that moved it [benchmarks] Run some models with smaller batch sizes. #6542model_name
byTorchBenchModel
attribute of same name@miladm