Scrub use of explicit PJRT_DEVICE=CUDA for Python CI/CD and rely on autodetection #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changm
changed the title
will-cromar
requested changes
Feb 29, 2024
There was a problem hiding this comment.
We should leave PJRT_DEVICE=CUDA set for almost all of our tests. We'd rather our CI crash if there was an issue with the GPU client vs silently falling back to CPU. See my comment here: #6605 (comment)
|
Ahh ack ok sorry I misread that versus a different comment. I'll close this then. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't do it for CPP tests since CPP uses a different PJRT C++ logic to directly read the PJRT_DEVICE to initialize.