Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply lower randperm #6482

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Reapply lower randperm #6482

merged 2 commits into from
Feb 8, 2024

Conversation

changm
Copy link
Collaborator

@changm changm commented Feb 6, 2024

Also copies test infrastructure for test_put and test_index_copy due to the use of randperm and PyTorch/XLA requiring mark_step() to materialize tensors.

@changm changm self-assigned this Feb 6, 2024
@changm changm requested a review from wonjoolee95 February 6, 2024 18:17
@changm
Copy link
Collaborator Author

changm commented Feb 6, 2024

Chatted offline. Verified that the new test_python_ops runs on (python_tests , xla_op1). You can see it in the logs under "test" at line 15400.

Copy link
Collaborator

@wonjoolee95 wonjoolee95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, @changm!

@changm changm enabled auto-merge (squash) February 8, 2024 19:05
@changm changm merged commit 157e06e into master Feb 8, 2024
2 checks passed
@changm changm deleted the changm/randperm branch February 8, 2024 19:40
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
Also updates test infrastructure to copy upstream pytorch test_input_copy and test_put to call XLA required `mark_step` during tests.
@lsy323 lsy323 mentioned this pull request Mar 26, 2024
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
Also updates test infrastructure to copy upstream pytorch test_input_copy and test_put to call XLA required `mark_step` during tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants