Fix some more core aten ops #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amithrm
pushed a commit
to amithrm/xla
that referenced
this pull request
Mar 1, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5848
aten::as_stridedis an op that should never be dispatched to torch_xla, as it is a view op and functionalization pass in PyTorch should decompose intoaten::as_strided_copy(as noted in https://github.com/pytorch/xla/blob/master/codegen/xla_native_functions.yaml#L387, note that functionalization is, by default, enabled in torch_xla and we want that to be the default/norm).Therefore, remove this from the test.Fixes #5861
Fixes #5859
Fixes #5897