rebase #6461
Merged
rebase #6461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Emilio Cota <[email protected]>
) This reverts commit 010b6f0. This should pass CI since CI now has the tabulate package.
…UCI run_e2e_tests (#6420)
Add some more styles and wrap around the style arrays so that we never access them out of bounds. While at it, fix --report=speedup plots to support missing points; matplotlib's errorbars take empty points as NaN's instead of None's.
Summary: This pull request tries to unify all TORCH_LIBRARY definitions across torch_xla into one xla library. Test Plan: CI
This fixes the following error, caught by yesterday's nightly run:
```
$ cd pytorch
$ python xla/benchmarks/experiment_runner.py --test=eval --test=train --xla=PJRT --dynamo=None --dynamo=openxla --dynamo=openxla_eval --suite-name=torchbench --accelerator=cuda --output-dirname=/tmp/foo --repeat=8 --print-subprocess --timestamp=1706835612
[...]
Traceback (most recent call last):
File "/home/ecg/nightly_runs/2024-02-02/pytorch/xla/benchmarks/experiment_runner.py", line 908, in <module>
main()
File "/home/ecg/nightly_runs/2024-02-02/pytorch/xla/benchmarks/experiment_runner.py", line 903, in main
runner = ExperimentRunner(args)
File "/home/ecg/nightly_runs/2024-02-02/pytorch/xla/benchmarks/experiment_runner.py", line 41, in __init__
self.model_loader = TorchBenchModelLoader(self._args)
File "/home/ecg/nightly_runs/2024-02-02/pytorch/xla/benchmarks/torchbench_model.py", line 160, in __init__
self.skip = self.get_skip_data()
File "/home/ecg/nightly_runs/2024-02-02/pytorch/xla/benchmarks/torchbench_model.py", line 202, in get_skip_data
with open(skip_file) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/ecg/nightly_runs/2024-02-02/pytorch/benchmarks/dynamo/dynamo/torchbench_skip_models.yaml'
```
ManfeiBai
requested review from
will-cromar,
JackCaoG,
yeounoh,
mateuszlewko and
stgpetrovic
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.