Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on how to integrate with dynamo #6459

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

changm
Copy link
Collaborator

@changm changm commented Feb 2, 2024

No description provided.

@changm changm requested a review from cota February 2, 2024 20:48
@changm changm self-assigned this Feb 2, 2024
@@ -58,6 +58,10 @@ report sent to us if you have it.

You can enable the PyTorch/XLA debugging tool by setting `PT_XLA_DEBUG=1`, which provides a couple useful debugging features.

## PyTorch/XLA + Dynamo Debugging Tool

You can enable the PyTorch/XLA + Dynamo debugging tool by setting `XLA_DYNAMO_DEBUG=1`, which provides a couple useful debugging features.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Nit-picking)
I see that this is copied from above, but without mentioning those "couple [of] useful debugging features", the statement is redundant.
I suggest we drop everything after the comma (, which provides...).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I can add a suggestion, let me do that.

TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/dynamo.md Outdated Show resolved Hide resolved
@cota
Copy link
Collaborator

cota commented Feb 6, 2024

Thanks for this! Just left some small suggestions.

Note: Not necessary since this is just a doc change, but in case you're wondering: in order to get CI not to time out, you would have to push this change to a branch on the main repo -- the build cache is enabled there, which speeds up CI builds considerably.

changm and others added 2 commits February 6, 2024 09:52
Co-authored-by: Emilio Cota <[email protected]>
Co-authored-by: Emilio Cota <[email protected]>
@changm
Copy link
Collaborator Author

changm commented Feb 6, 2024

Ahh thanks for the heads up. Yeah I tried another PR that committed to master and that seemed to work. I also committed your changes here, let me know if there's anything else you'd like to change.

@changm changm merged commit d0dd1a7 into pytorch:master Feb 6, 2024
5 of 6 checks passed
@changm changm deleted the dynamo branch February 6, 2024 22:27
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants