-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs on how to integrate with dynamo #6459
Conversation
TROUBLESHOOTING.md
Outdated
@@ -58,6 +58,10 @@ report sent to us if you have it. | |||
|
|||
You can enable the PyTorch/XLA debugging tool by setting `PT_XLA_DEBUG=1`, which provides a couple useful debugging features. | |||
|
|||
## PyTorch/XLA + Dynamo Debugging Tool | |||
|
|||
You can enable the PyTorch/XLA + Dynamo debugging tool by setting `XLA_DYNAMO_DEBUG=1`, which provides a couple useful debugging features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Nit-picking)
I see that this is copied from above, but without mentioning those "couple [of] useful debugging features", the statement is redundant.
I suggest we drop everything after the comma (, which provides...
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I can add a suggestion, let me do that.
Thanks for this! Just left some small suggestions. Note: Not necessary since this is just a doc change, but in case you're wondering: in order to get CI not to time out, you would have to push this change to a branch on the main repo -- the build cache is enabled there, which speeds up CI builds considerably. |
Co-authored-by: Emilio Cota <[email protected]>
Co-authored-by: Emilio Cota <[email protected]>
Ahh thanks for the heads up. Yeah I tried another PR that committed to master and that seemed to work. I also committed your changes here, let me know if there's anything else you'd like to change. |
Co-authored-by: Emilio Cota <[email protected]>
Co-authored-by: Emilio Cota <[email protected]>
No description provided.