Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify TORCH_LIBRARY definitions #6455

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Unify TORCH_LIBRARY definitions #6455

merged 6 commits into from
Feb 2, 2024

Conversation

alanwaketan
Copy link
Collaborator

Summary:
This pull request tries to unify all TORCH_LIBRARY definitions across torch_xla into one xla library.

Test Plan:
CI

@alanwaketan alanwaketan self-assigned this Feb 2, 2024
@alanwaketan alanwaketan marked this pull request as draft February 2, 2024 01:36
Copy link
Collaborator

@wonjoolee95 wonjoolee95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change! LGTM pending CI.

Copy link
Collaborator

@lsy323 lsy323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alanwaketan for making the change!

@alanwaketan alanwaketan marked this pull request as ready for review February 2, 2024 18:23
@alanwaketan alanwaketan changed the title [WIP] Unify TORCH_LIBRARY definitions Unify TORCH_LIBRARY definitions Feb 2, 2024
@alanwaketan
Copy link
Collaborator Author

Thanks for the review Siyuan and Wonjoo.

@alanwaketan alanwaketan merged commit 19923bd into master Feb 2, 2024
18 checks passed
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
Summary:
This pull request tries to unify all TORCH_LIBRARY definitions across torch_xla into one xla library.

Test Plan:
CI
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
Summary:
This pull request tries to unify all TORCH_LIBRARY definitions across torch_xla into one xla library.

Test Plan:
CI
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
Summary:
This pull request tries to unify all TORCH_LIBRARY definitions across torch_xla into one xla library.

Test Plan:
CI
amithrm pushed a commit to amithrm/xla that referenced this pull request May 28, 2024
Summary:
This pull request tries to unify all TORCH_LIBRARY definitions across torch_xla into one xla library.

Test Plan:
CI
amithrm pushed a commit to amithrm/xla that referenced this pull request May 29, 2024
Summary:
This pull request tries to unify all TORCH_LIBRARY definitions across torch_xla into one xla library.

Test Plan:
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants