Reenable TestPoolingNNDeviceTypeXLA #6453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qihqi
force-pushed
the
qihqi/core_aten_ops
branch
from
5fd627f to
75570d2
Compare
qihqi
changed the title
qihqi
force-pushed
the
qihqi/core_aten_ops
branch
from
75570d2 to
d4594e2
Compare
JackCaoG
reviewed
Feb 2, 2024
Comment on lines
+148
to
+152
| int64_t new_output_size = | ||
| (input_size + left_padding + right_padding + extra_padding - | ||
| kernel_size[i] + stride[i] - 1) / | ||
| stride[i] + | ||
| 1; |
There was a problem hiding this comment.
lol this computation is really puzzling. reminds me other leetcode questions.
There was a problem hiding this comment.
this is what was there before: https://github.com/pytorch/xla/pull/6409/files#diff-b7dcec47bb003c09d0f32235e139ca6f1bb411e30a5194a68d9745cb25032371L143
I thought those are too complex and useless so i removed them... turns out it's useful something
JackCaoG
approved these changes
Feb 2, 2024
amithrm
pushed a commit
to amithrm/xla
that referenced
this pull request
Mar 1, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.