Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert: #6368 to fix nightly CI coverage run." #6445

Closed
wants to merge 1 commit into from
Closed

Revert "Revert: #6368 to fix nightly CI coverage run." #6445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ function run_torch_xla_tests() {
export CXX_ABI=$(python -c "import torch;print(int(torch._C._GLIBCXX_USE_CXX11_ABI))")

# TODO(yeounoh) test coverage workflow is not parallelized.
if [[ -z "$RUN_BENCHMARK_TESTS" && -z "$RUN_CPP_TESTS1" && -z "$RUN_CPP_TESTS2" && -z "$RUN_PYTHON_TESTS" ]]; then
if [[ -z "$RUN_BENCHMARK_TESTS" && -z "$RUN_CPP_TESTS1" && -z "$RUN_CPP_TESTS2" && -z "$RUN_PYTHON_TESTS" || "$USE_COVERAGE" != "0" ]]; then
run_torch_xla_python_tests $PYTORCH_DIR $XLA_DIR $USE_COVERAGE
run_torch_xla_cpp_tests $PYTORCH_DIR $XLA_DIR $USE_COVERAGE
run_torch_xla_benchmark_tests $XLA_DIR
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,15 +125,9 @@ jobs:
env:
CIRCLE_WORKFLOW_ID: ${{ github.run_id }}
CIRCLE_BUILD_NUM: ${{ github.run_number }}
BENCHMARK_TEST_NAME: ${{ env.RUN_BENCHMARK_TESTS }}
PYTHON_TEST_NAME: ${{ env.RUN_PYTHON_TESTS }}${{ env.RUN_XLA_OP_TESTS1 }}${{ env.RUN_XLA_OP_TESTS2 }}${{ env.RUN_XLA_OP_TESTS3 }}${{ env.RUN_TORCH_MP_OP_TESTS }}
PYTHON_TEST_NAME: ${{ env.RUN_BENCHMARK_TESTS }}${{ env.RUN_PYTHON_TESTS }}${{ env.RUN_XLA_OP_TESTS1 }}${{ env.RUN_XLA_OP_TESTS2 }}${{ env.RUN_XLA_OP_TESTS3 }}${{ env.RUN_TORCH_MP_OP_TESTS }}
CPP_TEST_NAME: ${{ env.RUN_CPP_TESTS1 }}${{ env.RUN_CPP_TESTS2 }}
run: |
# TODO(yeounoh) collect coverage report as needed.
if [ -n "${BENCHMARK_TEST_NAME}" ] || [ "${PYTHON_TEST_NAME}" == "pythontorch_mp_op" ]; then
exit 0
fi

docker cp "${pid}":/home/jenkins/htmlcov "${GITHUB_WORKSPACE}"
if [ -n "${GPU_FLAG:-}" ]; then
if [ -n "${PYTHON_TEST_NAME}" ]; then
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
docker-image: ${{ needs.build.outputs.docker-image }}
runner: linux.8xlarge.nvidia.gpu
timeout-minutes: 300
collect-coverage: ${{ github.event_name == 'push' && github.event.ref == 'refs/heads/master' }}
collect-coverage: false #${{ github.event_name == 'push' && github.event.ref == 'refs/heads/master' }}
disable-xrt: 1
secrets:
gcloud-service-key: ${{ secrets.GCLOUD_SERVICE_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion test/pytorch_test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
'test_sum_xla_bfloat16': 0.1,
'test_put_xla_bfloat16': 0.05,
'test_take_xla_bfloat16': 0.05,
'test_EmbeddingBag_per_sample_weights_and_new_offsets_xla': 0.01,
}

DISABLED_TORCH_TESTS_ANY = {
Expand Down Expand Up @@ -316,6 +315,7 @@
'test_embedding_bag_device', # FIXME! Unsupported device type for sparse layout: xla
'test_embedding_scalar_weight_error_xla', # tsl::CurrentStackTrace[abi:cxx11]
'test_EmbeddingBag_per_sample_weights_and_no_offsets', # FIXME! Unsupported device type for sparse layout: xla
'test_EmbeddingBag_per_sample_weights_and_new_offsets', # precision
},

# test/nn/test_convolution.py
Expand Down
Loading