-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disambiguate benchmarks
directory search.
#6434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Oh, just noticed that it is still unable to find the |
@zpcore Interesting. How are the repos (PyTorch and PyTorch/XLA) organized in CI (or wherever you are trying to run the benchmarks)? |
Hi @ysiraichi , I tried the following organization:
In this case, it will not search under pytorch folder. |
Hmm... I see. What do you say we leave both of them: |
Yes, this should also work. Thanks! |
Follow-up: #6428
This PR disambiguates
pytorch/benchmarks
directory fromxla/benchmarks
directory. In order to do that without relying on the name of the directory that the repo lives, we look forbenchmarks/dynamo
, instead. Works, since thedynamo
directory only exists onpytorch/benchmarks
.cc @miladm