Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate benchmarks directory search. #6434

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

ysiraichi
Copy link
Collaborator

Follow-up: #6428

This PR disambiguates pytorch/benchmarks directory from xla/benchmarks directory. In order to do that without relying on the name of the directory that the repo lives, we look for benchmarks/dynamo, instead. Works, since the dynamo directory only exists on pytorch/benchmarks.

cc @miladm

@ysiraichi ysiraichi requested a review from zpcore January 31, 2024 21:02
Copy link
Collaborator

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@zpcore zpcore merged commit 599b925 into master Feb 1, 2024
18 checks passed
@zpcore
Copy link
Collaborator

zpcore commented Feb 1, 2024

Oh, just noticed that it is still unable to find the benchmarks/dynamo, because the file is under pytorch/. Let's add 'pytorch/benchmarks' instead... Let me revert this one for now.

zpcore added a commit that referenced this pull request Feb 1, 2024
@ysiraichi
Copy link
Collaborator Author

@zpcore Interesting. How are the repos (PyTorch and PyTorch/XLA) organized in CI (or wherever you are trying to run the benchmarks)?

@zpcore
Copy link
Collaborator

zpcore commented Feb 1, 2024

Hi @ysiraichi , I tried the following organization:

|--pytorch
|  --benchmarks
|     --dynamo
|     --...
|--xla
|  --benchmarks  <- I am running under this folder
|      -- 

In this case, it will not search under pytorch folder.

@ysiraichi
Copy link
Collaborator Author

Hmm... I see. What do you say we leave both of them: ("benchmarks/dynamo", "pytorch/benchmarks")?

@zpcore
Copy link
Collaborator

zpcore commented Feb 1, 2024

Yes, this should also work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants