Add option to register installed plugins automatically #6328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-cromar
requested review from
jonb377,
JackCaoG and
vanbasten23
and removed request for
jonb377
|
Marking this a draft for now while I figure out how to register |
JackCaoG
reviewed
Jan 19, 2024
JackCaoG
approved these changes
Jan 19, 2024
vanbasten23
reviewed
Jan 19, 2024
vanbasten23
reviewed
Jan 19, 2024
|
|
||
|
|
||
| def register_installed_plugins(): | ||
| pjrt_entry_points = importlib_metadata.entry_points(group='torch_xla.plugins') |
There was a problem hiding this comment.
I see that you have 'torch_xla.plugins': ['tpu = torch_xla._internal.tpu:TpuPlugin',], in the setup.py. I wonder what this line does under the hood
There was a problem hiding this comment.
Entry points are weird. setuptools' docs have the best explanation that I've read.
|
Tested manually on TPU to confirm that this works. |
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6242 for context
XLA_REGISTER_INSTALLED_PLUGINSto automatically register any plugin with thetorch_xla.pluginsentry point.importlib.metadata, which are backported inimportlib_metadata.