Use SGD for list of models from PyTorch. #6324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
requested review from
frgossen,
golechwierowicz,
cota and
vanbasten23
vanbasten23
approved these changes
Jan 19, 2024
| @@ -29,6 +29,27 @@ | |||
| "detectron2_fcos_r_50_fpn", | |||
| } | |||
|
|
|||
| # torchbench models that might OOM using Adam. | |||
| # This list was extracted from PyTorch's repository: benchmarks/dynamo/common.py | |||
There was a problem hiding this comment.
So in the link it is mentioned that they use Adam optimiser in the CI. What optimiser is used in the official PyTorch HUD? I'm asking because we want to be as close as possible.
There was a problem hiding this comment.
Good catch. So, maybe we want to get the previous set: BENCHMARK_USE_SGD, which is used outside CI.
ysiraichi
force-pushed
the
ysiraichi/fix-model-optimizer
branch
from
cfae238 to
b6d6acd
Compare
zpcore
pushed a commit
that referenced
this pull request
Jan 22, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces Adam for SGD optimizer for a few models that are tight on memory. This list was taken from PyTorch's main repository:
https://github.com/pytorch/pytorch/blob/eba5d5485dd3232737ac789f1614f4cbc09220a4/benchmarks/dynamo/common.py#L214-L252