Improve build process for PJRT plugins #6314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-cromar
force-pushed
the
wcromar/plugin-packaging
branch
from
e4c3d85 to
ef4016c
Compare
|
baf70be adds the CUDA plugin to the CI build, but the default behavior will remain the same. If it unnecessarily extends the build time, I'll revert it. |
This reverts commit baf70be.
|
The build failed, so I reverted the change. I'll debug this in a future PR. |
JackCaoG
reviewed
Jan 19, 2024
JackCaoG
reviewed
Jan 19, 2024
Comment on lines
-205
to
-210
| IS_DARWIN = (platform.system() == 'Darwin') | ||
| IS_WINDOWS = sys.platform.startswith('win') | ||
| IS_LINUX = (platform.system() == 'Linux') | ||
| GCLOUD_KEY_FILE = os.getenv('GCLOUD_SERVICE_KEY_FILE', default='') | ||
| CACHE_SILO_NAME = os.getenv('SILO_NAME', default='dev') | ||
| BAZEL_JOBS = os.getenv('BAZEL_JOBS', default='') |
There was a problem hiding this comment.
are these no longer needed?
There was a problem hiding this comment.
The OS flags are irrelevant since we only support linux. The others were moved into local variables
JackCaoG
approved these changes
Jan 19, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: directly running
setup.pyis now deprecated. Both plugins are now installable by runningpip install plugin/..., which runssetuptools/setup.pyin the background. We'll have to deal with this problem in our mainsetup.pybuild soon too.setup.pyBazelExtensionandBuildBazelExtensionare not necessary for the plugins because they don't expose any functions to Python like_XLACdoes. Instead, I opted to run bazel in a subprocess before runningsetup. According tosetuptools's docs, the "right" way to extendsetuptoolsis to add commands, but customsetup.pycommands are being deprecated (since you have to invoke it through pip). The documentation doesn't make it clear what the right thing to do here is, so I opted for the most straightforward solution. (Not to mention, the documentation about how to actually write custom commands is also sparse.)build_utiland symlink it to plugin directoriessetup.pywithpip's build isolation, so I disabled isolation with--no-build-isolation. The only way I see how to do this is to install our build-time library as a package, but it seems silly to create a package that will only be used to build our real packages in the same repository.The current state of Python packaging is kind of a mess. See these three blog posts for a pretty good summary of grievances with the current situation. I'm very open to feedback on this PR, since I'm not at all convinced I'm using the new tools the "right" way (if there even is one).
The bright side is,
pyproject.tomlwill make it much easier to get away fromsetuptoolsif we want to do that. Especially when we have to deal with our mainsetup.py, we should look to see if any of the alternatives better support our use case with less hackery. (I did some research this week, but most alternatives, including PyPA'shatchdo not support C++ extensions).