Forward subprocess stdout and stderr in all cases #6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frgossen
force-pushed
the
frg-fix-fwd-subprocess-output
branch
2 times, most recently
from
79afee5 to
57bef18
Compare
|
Sorry to be that guy. Can you break up the patch into the NFC bits and the ones that matter? |
|
What I mean is: this PR will go in as a single commit that doesn't fully reflect what the code changes are. |
|
As discussed offline, the diff includes dependent PRs. Will let the CI finish and rebase then. |
|
All checks have passed |
frgossen
force-pushed
the
frg-fix-fwd-subprocess-output
branch
from
57bef18 to
d697389
Compare
Previously output was not forwarded in failure cases.
frgossen
force-pushed
the
frg-fix-fwd-subprocess-output
branch
from
d697389 to
3bf52fd
Compare
cota
approved these changes
Dec 15, 2023
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously output was not forwarded in failure cases.