Reapply with fix "Add comments to _is_available and raise exceptions … #6143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cota
reviewed
Dec 13, 2023
benchmarks/benchmark_experiment.py
Outdated
| return False | ||
|
|
||
| # Check accelerator contraints. |
There was a problem hiding this comment.
Suggested change
| # Check accelerator contraints. | |
| # Check accelerator constraints. |
cota
approved these changes
Dec 13, 2023
frgossen
force-pushed
the
frg-bm-e-is-available
branch
2 times, most recently
from
b324d4e to
a9d1b76
Compare
frgossen
force-pushed
the
frg-bm-e-is-available
branch
from
a9d1b76 to
d2abd29
Compare
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in unimple… (#6141)
This reverts commit ddc2e34.
Use
is_xla_device_availableto check CUDA device.