Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow benchmark runner config: openxla for inference runs. … #6096

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions benchmarks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,9 @@ python xla/benchmarks/experiment_runner.py \
You can change the flags to add the configurations you are interested in. The
`experiment_runner.py` will expand the options to all supported configurations.
For example, in the case above, it will consider all the possible combinations
among the flags `--dynamo`, `--xla`, and `--test`, 5 of which are supported:
among the flags `--dynamo`, `--xla`, and `--test`, 4 of which are supported:

- `dynamo=openxla_eval`, `xla=PJRT`, `test=eval`
- `dynamo=openxla`, `xla=PJRT`, `test=eval`
- `dynamo=openxla`, `xla=PJRT`, `test=train`
- `dynamo=inductor`, `xla=None`, `test=eval`
- `dynamo=inductor`, `xla=None`, `test=train`
Expand Down
3 changes: 2 additions & 1 deletion benchmarks/benchmark_experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ def is_available(self, experiment_config):
if experiment_config["dynamo"] == "openxla_eval" and not (
experiment_config["xla"] and experiment_config["test"] == "eval"):
return False
if experiment_config["dynamo"] == "openxla" and not experiment_config["xla"]:
if experiment_config["dynamo"] == "openxla" and not (
experiment_config["xla"] and experiment_config["test"] == "train"):
return False
if (experiment_config["xla"] and
not is_xla_device_available(experiment_config["accelerator"].upper())):
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/experiment_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ def parse_args(args=None):
"--collect-full-output",
action="store_true",
help="""Whether to collect full output for training. Set this to true if we
want to verify the numerical correctness of gradients. But that may
want to verify the numerical correctness of graidents. But that may
cause time measurement not accurate""",
)

Expand Down
Loading