Allow benchmark runner config: openxla for inference runs.
#5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frgossen
requested changes
Nov 30, 2023
|
@frgossen Let me know if that is good enough. |
frgossen
approved these changes
Dec 1, 2023
| @@ -32,9 +32,10 @@ python xla/benchmarks/experiment_runner.py \ | |||
| You can change the flags to add the configurations you are interested in. The | |||
| `experiment_runner.py` will expand the options to all supported configurations. | |||
| For example, in the case above, it will consider all the possible combinations | |||
| among the flags `--dynamo`, `--xla`, and `--test`, 4 of which are supported: | |||
| among the flags `--dynamo`, `--xla`, and `--test`, 5 of which are supported: | |||
|
|
|||
| - `dynamo=openxla_eval`, `xla=PJRT`, `test=eval` | |||
There was a problem hiding this comment.
Think you have to remove this line. It will still be 4 configs overall.
There was a problem hiding this comment.
Not sure if I get why that is the case. Isn't the following combination supported in addition to the ones already specified in the readme?
dynamo=openxla,xla=PJRT,test=eval
There was a problem hiding this comment.
Maybe I misunderstand this change then. I thought you were getting rid of openxla_eval in favor of openxla. My thought was we'd have to remove dynamo=openxla_eval here.
ysiraichi
commented
Dec 1, 2023
benchmarks/benchmark_experiment.py
Outdated
Comment on lines
88
to
90
| if experiment_config["dynamo"] == "openxla_eval" and not ( | ||
| experiment_config["xla"] and experiment_config["test"] == "eval"): | ||
| return False |
There was a problem hiding this comment.
I think I need to revert this deletion. openxla_eval is only supposed to work with eval test.
frgossen
added a commit
to frgossen/pytorch-xla
that referenced
this pull request
Dec 11, 2023
…ytorch#5939)" This reverts commit dcdd66e.
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
…#5939) * Allow openxla for eval. * Update readme. * Revert `openxla_eval` rule.
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Allow openxla for eval. * Update readme. * Revert `openxla_eval` rule.
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Allow openxla for eval. * Update readme. * Revert `openxla_eval` rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the benchmarking script, enabling
openxladynamo backend for inference runs.