Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark noise reducing info. #5924

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

golechwierowicz
Copy link
Collaborator

Add info about knobs making benchmarks more stable across different runs.

Add info about knobs making benchmarks more stable
across different runs.
benchmarks/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@frgossen frgossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

benchmarks/README.md Outdated Show resolved Hide resolved
@miladm miladm requested a review from zpcore November 28, 2023 16:28
@zpcore
Copy link
Collaborator

zpcore commented Nov 29, 2023

Quick questions:

  • Is there a recommendation/consensus GPU freq we can use throughout different model testing so that we can compare the results under the same constraint in the same platform?
  • Also want to check if the GPU freq can be set arbitrarily as long as it is below the maximum or there is only limited options we can choose from.

@zpcore zpcore merged commit c8ce062 into master Nov 29, 2023
18 checks passed
@frgossen frgossen deleted the olechwierowicz/add-benchmark-documentation branch November 30, 2023 00:45
@golechwierowicz
Copy link
Collaborator Author

Quick questions:

  • Is there a recommendation/consensus GPU freq we can use throughout different model testing so that we can compare the results under the same constraint in the same platform?
  • Also want to check if the GPU freq can be set arbitrarily as long as it is below the maximum or there is only limited options we can choose from.
  1. I don't think there is a consensus among the team, it will be good to establish it now. (given everyone runs benchmarks manually, once we have an automated suite it will be unnecessary though)
  2. AFAIK it has to below the maximum, above the minimum, and it has to be the multiple of 15. But the entire point is setting it to such a value so that thermal throttling does not kick in, and there is no random slowdown on computation. So setting it to ~80% of the maximum seems like a good idea.

ManfeiBai pushed a commit to ManfeiBai/PyTorchXLA that referenced this pull request Dec 1, 2023
* Add benchmark noise reducing info.

Add info about knobs making benchmarks more stable
across different runs.

* Add more general info about setting clock freq.

* Move comments out of the code
ManfeiBai pushed a commit to ManfeiBai/PyTorchXLA that referenced this pull request Dec 1, 2023
* Add benchmark noise reducing info.

Add info about knobs making benchmarks more stable
across different runs.

* Add more general info about setting clock freq.

* Move comments out of the code
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
* Add benchmark noise reducing info.

Add info about knobs making benchmarks more stable
across different runs.

* Add more general info about setting clock freq.

* Move comments out of the code
golechwierowicz added a commit that referenced this pull request Jan 12, 2024
* Add benchmark noise reducing info.

Add info about knobs making benchmarks more stable
across different runs.

* Add more general info about setting clock freq.

* Move comments out of the code
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
* Add benchmark noise reducing info.

Add info about knobs making benchmarks more stable
across different runs.

* Add more general info about setting clock freq.

* Move comments out of the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants