Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tolerance for tan #5915

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Increase tolerance for tan #5915

merged 1 commit into from
Dec 1, 2023

Conversation

qihqi
Copy link
Collaborator

@qihqi qihqi commented Nov 22, 2023

fixes #5902

@qihqi qihqi force-pushed the core_aten_ops branch 2 times, most recently from 0e74a0c to 86d6596 Compare November 22, 2023 22:25
Copy link
Collaborator

@wonjoolee95 wonjoolee95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The docs/fixing_core_aten_ops_log.md is a good idea, but maybe we can move this to a GitHub issue so folks can freely update/comment rather than having it go through a PR?

@qihqi
Copy link
Collaborator Author

qihqi commented Nov 29, 2023

LGTM! The docs/fixing_core_aten_ops_log.md is a good idea, but maybe we can move this to a GitHub issue so folks can freely update/comment rather than having it go through a PR?

Good idea! #5934

@qihqi qihqi force-pushed the core_aten_ops branch 2 times, most recently from c2436dd to ea57582 Compare November 29, 2023 01:01
@qihqi qihqi force-pushed the core_aten_ops branch 2 times, most recently from 53d1c32 to 5d0108e Compare December 1, 2023 07:18
@qihqi qihqi merged commit 2c4983d into pytorch:master Dec 1, 2023
18 checks passed
ManfeiBai pushed a commit to ManfeiBai/PyTorchXLA that referenced this pull request Dec 1, 2023
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
golechwierowicz pushed a commit that referenced this pull request Jan 12, 2024
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core ATen Opset] Lower aten_tan
2 participants