Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set $TPU_LIBRARY_PATH during import #5794

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Don't set $TPU_LIBRARY_PATH during import #5794

merged 1 commit into from
Nov 14, 2023

Conversation

will-cromar
Copy link
Collaborator

See #5698 and #5731. Once we remove tpu_tracer (#5793), we no longer need to set TPU_LIBRARY_PATH.

@will-cromar will-cromar added DO_NOT_MERGE_YET For PRs which cannot be merged, despite tests passing runtime labels Nov 13, 2023
JackCaoG
JackCaoG approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the existing profiler test enough to cover the testing? or it has to be you manually patch and test?

@will-cromar
Copy link
Collaborator Author

Our existing profiler test does not check for device traces, so I had to test manually.

alanwaketan
alanwaketan approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Base automatically changed from wcromar/tpu-profiler-plugin to master November 14, 2023 17:56
@will-cromar will-cromar force-pushed the wcromar/fix-libtpu-init-again branch from b9d868e to a85a724 Compare November 14, 2023 17:58
@will-cromar will-cromar removed the DO_NOT_MERGE_YET For PRs which cannot be merged, despite tests passing label Nov 14, 2023
@will-cromar will-cromar merged commit d8c6a83 into master Nov 14, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackCaoG JackCaoG JackCaoG approved these changes

@alanwaketan alanwaketan alanwaketan approved these changes

Assignees
No one assigned
Labels
runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@will-cromar @alanwaketan @JackCaoG