Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unused code from csrc/runtime #5785

Merged
merged 9 commits into from
Nov 13, 2023
Merged

Remove some unused code from csrc/runtime #5785

merged 9 commits into from
Nov 13, 2023

Conversation

will-cromar
Copy link
Collaborator

@will-cromar will-cromar commented Nov 9, 2023 •
edited
Loading

  • nccl_distributed and async_task are completely unused
  • hash functions and Unique already exist upstream
  • Delete some more random unused or duplicated functions from util.h

MultiWait is also duplicated upstream, but I have separate plans for that one.

@will-cromar will-cromar marked this pull request as ready for review November 9, 2023 20:16
@JackCaoG
Copy link
Collaborator

I don't think Unique and optional are the same, when you try to call set on a Unique it will give a error. I don't think optional has that property.

@will-cromar
Copy link
Collaborator Author

Got it. Switched our code to use the upstream copy of Unique.

@will-cromar will-cromar merged commit 79557cc into master Nov 13, 2023
17 checks passed
JackCaoG added a commit that referenced this pull request Nov 13, 2023
@JackCaoG
Revert "Remove some unused code from csrc/runtime (#5785)"
da5391e 
This reverts commit 79557cc.
alanwaketan
alanwaketan reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code crusher!

mbzomowski pushed a commit to mbzomowski-test-org/xla that referenced this pull request Nov 16, 2023
@will-cromar @mbzomowski
Remove some unused code from csrc/runtime (pytorch#5785)
8285dfc 
* delete nccl_distributed

* remove async_task

* remove unique

* Remove hashing

* more random cleanup

* formatting

* remove util.cc

* Revert "remove unique"

This reverts commit ebe4567.

* Use upstream Unique
@mbzomowski mbzomowski mentioned this pull request Nov 16, 2023
Merged
zpcore pushed a commit that referenced this pull request Nov 21, 2023
@will-cromar @zpcore
Remove some unused code from csrc/runtime (#5785)
840875e 
* delete nccl_distributed

* remove async_task

* remove unique

* Remove hashing

* more random cleanup

* formatting

* remove util.cc

* Revert "remove unique"

This reverts commit ebe4567.

* Use upstream Unique
lsy323 pushed a commit to lsy323/xla that referenced this pull request Nov 28, 2023
@will-cromar
Remove some unused code from csrc/runtime (pytorch#5785)
d2c0da7 
* delete nccl_distributed

* remove async_task

* remove unique

* Remove hashing

* more random cleanup

* formatting

* remove util.cc

* Revert "remove unique"

This reverts commit ebe4567.

* Use upstream Unique
ManfeiBai pushed a commit that referenced this pull request Nov 29, 2023
@will-cromar @ManfeiBai
Remove some unused code from csrc/runtime (#5785)
94a12a2 
* delete nccl_distributed

* remove async_task

* remove unique

* Remove hashing

* more random cleanup

* formatting

* remove util.cc

* Revert "remove unique"

This reverts commit ebe4567.

* Use upstream Unique
ManfeiBai pushed a commit that referenced this pull request Nov 29, 2023
@will-cromar @ManfeiBai
Remove some unused code from csrc/runtime (#5785)
8166a01 
* delete nccl_distributed

* remove async_task

* remove unique

* Remove hashing

* more random cleanup

* formatting

* remove util.cc

* Revert "remove unique"

This reverts commit ebe4567.

* Use upstream Unique
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
@will-cromar @chunnienc
Remove some unused code from csrc/runtime (pytorch#5785)
bc712f8 
* delete nccl_distributed

* remove async_task

* remove unique

* Remove hashing

* more random cleanup

* formatting

* remove util.cc

* Revert "remove unique"

This reverts commit ebe4567.

* Use upstream Unique
golechwierowicz pushed a commit that referenced this pull request Jan 12, 2024
@will-cromar @golechwierowicz
Remove some unused code from csrc/runtime (#5785)
e9c4521 
* delete nccl_distributed

* remove async_task

* remove unique

* Remove hashing

* more random cleanup

* formatting

* remove util.cc

* Revert "remove unique"

This reverts commit ebe4567.

* Use upstream Unique
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
@will-cromar @bhavya01
Remove some unused code from csrc/runtime (#5785)
6fbdecf 
* delete nccl_distributed

* remove async_task

* remove unique

* Remove hashing

* more random cleanup

* formatting

* remove util.cc

* Revert "remove unique"

This reverts commit ebe4567.

* Use upstream Unique
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanwaketan alanwaketan alanwaketan left review comments

@JackCaoG JackCaoG JackCaoG approved these changes

Assignees
No one assigned
Labels
runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@will-cromar @JackCaoG @alanwaketan