Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip partitioner when there is no fallback #5756

Closed
wants to merge 1 commit into from
Closed

skip partitioner when there is no fallback #5756

wants to merge 1 commit into from

Conversation

JackCaoG
Copy link
Collaborator

@JackCaoG JackCaoG commented Nov 1, 2023

No description provided.

@JackCaoG JackCaoG added the dynamo label Nov 1, 2023
@JackCaoG JackCaoG requested a review from wonjoolee95 November 1, 2023 23:52
wonjoolee95
wonjoolee95 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@wonjoolee95 wonjoolee95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see if any unit tests complain 🤞

@JackCaoG
Copy link
Collaborator Author

JackCaoG commented Nov 2, 2023

test_non_tensor_args_for_partition failed, I will take a look

@JackCaoG
Copy link
Collaborator Author

JackCaoG commented Nov 3, 2023

It turned out that I can't just

xla_model.xla_args = xla_args

InputCollector actually helped to lift some non-tensor input(for example other nn module) to xla_model.xla_args. I am just going to close this pr for now. We can look into it later.

@JackCaoG JackCaoG closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonjoolee95 wonjoolee95 wonjoolee95 approved these changes

Assignees
No one assigned
Labels
dynamo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackCaoG @wonjoolee95