Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote in convolution #5727

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Promote in convolution #5727

merged 1 commit into from
Oct 25, 2023

Conversation

qihqi
Copy link
Collaborator

@qihqi qihqi commented Oct 24, 2023

Currently this model:

m = timm.create_model("efficientformerv2_s0",
        pretrained=True, scriptable=True).eval()`

will fail to convert to stablehlo because we use mixed shape in Conv. this is allowed in HLO but not in mhlo.

Workaroudn by manually promoting

Currently this model:

```
m = timm.create_model("efficientformerv2_s0",
        pretrained=True, scriptable=True).eval()`
```

will fail to convert to stablehlo because we use mixed shape in Conv.
this is allowed in HLO but not in mhlo.

Workaroudn by manually promoting
@qihqi qihqi requested a review from lsy323 October 24, 2023 17:54
@lsy323 lsy323 merged commit 47bf2ea into master Oct 25, 2023
17 checks passed
mbzomowski pushed a commit to mbzomowski-test-org/xla that referenced this pull request Nov 16, 2023
Currently this model:

```
m = timm.create_model("efficientformerv2_s0",
        pretrained=True, scriptable=True).eval()`
```

will fail to convert to stablehlo because we use mixed shape in Conv.
this is allowed in HLO but not in mhlo.

Workaroudn by manually promoting
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
Currently this model:

```
m = timm.create_model("efficientformerv2_s0",
        pretrained=True, scriptable=True).eval()`
```

will fail to convert to stablehlo because we use mixed shape in Conv.
this is allowed in HLO but not in mhlo.

Workaroudn by manually promoting
golechwierowicz pushed a commit that referenced this pull request Jan 12, 2024
Currently this model:

```
m = timm.create_model("efficientformerv2_s0",
        pretrained=True, scriptable=True).eval()`
```

will fail to convert to stablehlo because we use mixed shape in Conv.
this is allowed in HLO but not in mhlo.

Workaroudn by manually promoting
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
Currently this model:

```
m = timm.create_model("efficientformerv2_s0",
        pretrained=True, scriptable=True).eval()`
```

will fail to convert to stablehlo because we use mixed shape in Conv.
this is allowed in HLO but not in mhlo.

Workaroudn by manually promoting
@qihqi qihqi deleted the qihqi/stablehlo branch April 29, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants