-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker image and add CPU torch installation #5682
base: master
Are you sure you want to change the base?
Conversation
scripts/build_torch_wheels.sh
Outdated
@@ -336,6 +340,7 @@ function main() { | |||
build_and_install_torch | |||
pushd xla | |||
build_and_install_torch_xla | |||
install_libtpu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we use this script anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this script is used when build image if we build docker image using https://github.com/pytorch/xla/blob/master/docker/Dockerfile: https://github.com/pytorch/xla/blob/bf47009582d513d4068478f0e0e372657e1cabb8/docker/Dockerfile#L58C37-L58C58
add this func install_libtpu
might help INTERNAL: Failed to open libtpu.so: libtpu.so: cannot open shared object file: No such file or directory
, will see CI tests results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, but I thought re don't use that docker now, given our docker build is based on https://github.com/pytorch/xla/tree/master/infra . @will-cromar am I missing something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this docker file is not used anymore. I don't think we even use it in the TPU CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated to modify in https://github.com/pytorch/xla/tree/master/infra's Dockerfile
I'm not sure I understand the context. Nightly wheels already have libtpu bundled, so they won't need this. Is this problem on the release images? This image tag will have libtpu already installed: |
when i try to use docker image as a user from https://github.com/pytorch/xla#docker, i installed thanks for pointing this docker image |
Yeah, that's my bad. Thanks for catching it. Let's update the documented image to the |
Thanks, udpated do we want to build a wheel for py38 with libtpu too? now the 2.1 wheel for py38 is |
73b944d
to
a5ccdfe
Compare
add this command for
libtpu.so
file to fixINTERNAL: Failed to open libtpu.so: libtpu.so: cannot open shared object file: No such file or directory
when using docker image