Add fsdp tests back to GPU CI #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten23
changed the title
alanwaketan
approved these changes
Oct 6, 2023
JackCaoG
approved these changes
Oct 6, 2023
Just cc'ed you in the bug. Thanks Jiewen! |
|
Thanks for the review! |
vanbasten23
force-pushed
the
updatePinSlightly20230829
branch
from
e570496 to
80803f4
Compare
qihqi
pushed a commit
that referenced
this pull request
Oct 10, 2023
* use manfei's change * use the new flag * reduce data size * reduce batch size * keep reducing batch size to 64 * remove comments
zpcore
pushed a commit
that referenced
this pull request
Oct 19, 2023
* use manfei's change * use the new flag * reduce data size * reduce batch size * keep reducing batch size to 64 * remove comments
ghpvnist
pushed a commit
to ghpvnist/xla
that referenced
this pull request
Oct 31, 2023
* use manfei's change * use the new flag * reduce data size * reduce batch size * keep reducing batch size to 64 * remove comments
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
* use manfei's change * use the new flag * reduce data size * reduce batch size * keep reducing batch size to 64 * remove comments
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
* use manfei's change * use the new flag * reduce data size * reduce batch size * keep reducing batch size to 64 * remove comments
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
* use manfei's change * use the new flag * reduce data size * reduce batch size * keep reducing batch size to 64 * remove comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsdp test was broken in one of the tf pin updates.
This pr tests if it's possible to reenable it in the GPU CI and add it back if so.