Remove on_device_shape and logical_on_device_shape
#5546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-cromar
added
DO_NOT_MERGE_YET
will-cromar
changed the title
on_device_shape and logical_on_device_shapeon_device_shape and logical_on_device_shape
|
Once the openXLA change to add |
JackCaoG
approved these changes
Sep 9, 2023
will-cromar
force-pushed
the
wcromar/no-shapes
branch
from
9e1c0da to
e180883
Compare
vanbasten23
approved these changes
Sep 13, 2023
|
The upstream commit merged: openxla/xla@6308dba Added the hash to the patch in this commit. Let's wait until after we're done moving the OpenXLA pin to merge this (see #5592) |
will-cromar
removed
the
DO_NOT_MERGE_YET
|
Do we want this PR in 2.1 branch? |
|
No. This is a risky change, so we should not backport it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were removed from the PJRT C API client recently in this commit: tensorflow/tensorflow@840633c
Instead, we can rebuild the shapes from the decomposed components. In the future, we should see if we can remove
ShapefromComputationClient::Dataentirely in favor ofdimensions,layout, etc.