Skip to content

Commit

Permalink
Revert "Revert "Fix error: Failed to CreateArtifact: Received non-ret…
Browse files Browse the repository at this point in the history
…ryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run""

This reverts commit be6704a.
  • Loading branch information
vanbasten23 committed May 17, 2024
1 parent be6704a commit d8df552
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 7 deletions.
11 changes: 4 additions & 7 deletions .github/workflows/_build_torch_with_cuda_and_xla.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,11 @@ jobs:
shell: bash
run: |
cd pytorch/xla/infra/ansible
ansible-playbook playbook.yaml -vvv -e "stage=build arch=amd64 accelerator=cuda cuda_compute_capabilities=5.2,7.5 src_root=${GITHUB_WORKSPACE} build_cpp_tests=1 git_versioned_xla_build=1 cache_suffix=-ci build_pytorch_with_cuda=1" --skip-tags=fetch_srcs,install_deps
ansible-playbook playbook.yaml -vvv -e "stage=build arch=amd64 accelerator=cuda cuda_compute_capabilities=5.2,7.5 src_root=${GITHUB_WORKSPACE} build_cpp_tests=0 git_versioned_xla_build=1 cache_suffix=-ci build_pytorch_with_cuda=1" --skip-tags=fetch_srcs,install_deps
# TODO(xw32): remove the line below
ls /dist/
- name: Upload wheel
uses: actions/upload-artifact@v4
with:
name: torch-xla-wheels
name: torch-with-cuda-xla-with-cuda-wheels
path: /dist/*.whl
- name: Upload CPP test binaries
uses: actions/upload-artifact@v4
with:
name: cpp-test-bin
path: /tmp/test/bin
12 changes: 12 additions & 0 deletions .github/workflows/_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ on:
type: boolean
default: false
description: Whether to install CUDA plugin package
require-pytorch-cuda:
required: false
type: boolean
default: false
description: Whether the tests require pytorch built with CUDA enabled

secrets:
gcloud-service-key:
Expand Down Expand Up @@ -87,6 +92,13 @@ jobs:
with:
name: torch-xla-wheels
path: /tmp/wheels/
if: $! {{ require-pytorch-cuda }}
- name: Fetch wheels (pytorch and pytorch/xla with CUDA enabled) if needed.
uses: actions/download-artifact@v4
with:
name: torch-with-cuda-xla-with-cuda-wheels
path: /tmp/wheels/
if: ${{ require-pytorch-cuda }}
- name: Fetch CPP test binaries
uses: actions/download-artifact@v4
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ jobs:
timeout-minutes: 300
collect-coverage: false
install-cuda-plugin: true
require-pytorch-cuda: true
secrets:
gcloud-service-key: ${{ secrets.GCLOUD_SERVICE_KEY }}

Expand Down

0 comments on commit d8df552

Please sign in to comment.