Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removeable warnings indicating this is the last release #2248

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

NicolasHug
Copy link
Member

Test plan:

Every single one of these calls will raise the warning:

python -c "from torchtext import datasets"
python -c "import torchtext.datasets"
python -c "from torchtext.datasets import AG_NEWS"

python -c "from torchtext import data"
python -c "import torchtext.data"
python -c "from torchtext.data import custom_replace"

python -c "from torchtext import models"
python -c "import torchtext.models"
python -c "from torchtext.models import ROBERTA_BASE_ENCODER"

python -c "from torchtext import nn"
python -c "import torchtext.nn"
python -c "from torchtext.nn import InProjContainer"

python -c "from torchtext import utils"
python -c "import torchtext.utils"
python -c "from torchtext.utils import LOCK_TIMEOUT"

python -c "from torchtext import vocab"
python -c "import torchtext.vocab"
python -c "from torchtext.vocab import Vocab"

python -c "from torchtext import transforms"
python -c "import torchtext.transforms"
python -c "from torchtext.transforms import SentencePieceTokenizer"

python -c "from torchtext import functional"
python -c "import torchtext.functional"
python -c "from torchtext.functional import to_tensor"

python -c "from torchtext import prototype"
python -c "import torchtext.prototype"
python -c "from torchtext.prototype import transforms"

python -c "from torchtext import experimental"
python -c "import torchtext.experimental"
python -c "from torchtext.experimental import transforms"

While none of these calls will raise the warning:





python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext import datasets"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); import torchtext.datasets"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext.datasets import AG_NEWS"

python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext import data"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); import torchtext.data"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext.data import custom_replace"

python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext import models"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); import torchtext.models"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext.models import ROBERTA_BASE_ENCODER"

python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext import nn"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); import torchtext.nn"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext.nn import InProjContainer"

python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext import utils"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); import torchtext.utils"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext.utils import LOCK_TIMEOUT"

python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext import vocab"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); import torchtext.vocab"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext.vocab import Vocab"

python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext import transforms"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); import torchtext.transforms"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext.transforms import SentencePieceTokenizer"

python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext import functional"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); import torchtext.functional"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext.functional import to_tensor"

python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext import prototype"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); import torchtext.prototype"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext.prototype import transforms"

python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext import experimental"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); import torchtext.experimental"
python -c "import torchtext; torchtext.disable_torchtext_deprecation_warning(); from torchtext.experimental import transforms"

Copy link

pytorch-bot bot commented Mar 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2248

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 10 New Failures, 5 Unrelated Failures

As of commit d7b799a with merge base ecb9ebc (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug merged commit 4bf6b30 into pytorch:main Apr 2, 2024
21 of 37 checks passed
@NicolasHug NicolasHug deleted the aelfjnalfjenlajenf branch April 2, 2024 11:57
atalman pushed a commit to atalman/text that referenced this pull request Apr 11, 2024
atalman added a commit that referenced this pull request Apr 11, 2024
…lease (#2248) (#2257)

* Add removeable warnings indicating this is the last release (#2248)

* make pytorch dep a lower bound (#2256)

* Fix CNNDM dataset tests (#2246)

---------

Co-authored-by: Nicolas Hug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants