-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove torchdata dependency from package and from CI #2241
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2241
Note: Links to docs will display an error until the docs builds have been completed. ❌ 19 New Failures, 5 Unrelated FailuresAs of commit 9e13774 with merge base 52c0d85 (): NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
||
if channel == "nightly": | ||
validateTorchdataVersion() | ||
|
||
print("torchtext version is ", torchtext.__version__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could include 1-2 basic torchtext functionalities tests, here to see if they work. This can be done in followup pr
Co-authored-by: Nicolas Hug <[email protected]> Fix torchdata import error (#2242)
This PR removes the dependency on torchdata:
setup.py
/requirements.txt
, etc.)The files that still have references to torchdata after this PR are:
The
torchtext.datasets
namespace still relies on torchdata but that's OK: users who still need it can just install torchdata manually. Similarly I did not update/remove thetests/datasets/*
files and instead just ignored all the dataset tests inpytest.ini
.I will be submitting follow-up PRs to also address the user-facing docs, raise proper warnings, etc.