Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to validate from torchtext validate binaries call #2240

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

PaliC
Copy link
Contributor

@PaliC PaliC commented Mar 21, 2024

Adds option to validate against a specific version of pytorch

Copy link

pytorch-bot bot commented Mar 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2240

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 6 Unrelated Failures

As of commit 5dd1449 with merge base 656a3b4 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman
Copy link
Contributor

atalman commented Mar 21, 2024

Need to add a call to:

  generate-release-matrix:
    uses: pytorch/test-infra/.github/workflows/generate_release_matrix.yml@main
    with:
      version: ${{ inputs.version }}

See:
https://github.com/pytorch/builder/blob/main/.github/workflows/validate-binaries.yml#L106

@atalman
Copy link
Contributor

atalman commented Mar 21, 2024

Also need to change /.github/scripts/validate_binaries.sh to install required version of text retrieved from generate-release-matrix call

@atalman atalman merged commit 52c0d85 into main Mar 21, 2024
32 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants