Skip to content

Commit

Permalink
Fix typo: "a asynchronous" -> "an asynchronous" (#3314)
Browse files Browse the repository at this point in the history
Co-authored-by: Matthias Reso <[email protected]>
Co-authored-by: Ankith Gunapal <[email protected]>
  • Loading branch information
3 people authored Sep 16, 2024
1 parent c698fe0 commit 06d2d57
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,8 @@ private static Operation getUnRegisterOperation(boolean version) {
operationId = "version_unregisterModel";
} else {
operationDescription =
"Unregister the default version of a model from TorchServe if it is the only version available."
+ "This is a asynchronous call by default. Caller can call listModels to confirm model is unregistered";
"Unregister the default version of a model from TorchServe if it is the only version available. "
+ "This is an asynchronous call by default. Caller can call listModels to confirm model is unregistered.";
operationId = "unregisterModel";
}
Operation operation = new Operation(operationId, operationDescription);
Expand Down Expand Up @@ -482,12 +482,12 @@ private static Operation getScaleOperation(boolean version) {
if (version) {
operationDescription =
"Configure number of workers for a specified version of a model. "
+ "This is a asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.";
+ "This is an asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.";
operationId = "version_setAutoScale";
} else {
operationDescription =
"Configure number of workers for a default version of a model."
+ "This is a asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.";
"Configure number of workers for a default version of a model. "
+ "This is an asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.";
operationId = "setAutoScale";
}

Expand Down
6 changes: 3 additions & 3 deletions frontend/server/src/main/resources/proto/management.proto
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,12 @@ service ManagementAPIsService {
// Register a new model in TorchServe.
rpc RegisterModel(RegisterModelRequest) returns (ManagementResponse) {}

// Configure number of workers for a default version of a model.This is a asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.
// Configure number of workers for a default version of a model. This is an asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.
rpc ScaleWorker(ScaleWorkerRequest) returns (ManagementResponse) {}

// Set default version of a model
rpc SetDefault(SetDefaultRequest) returns (ManagementResponse) {}

// Unregister the default version of a model from TorchServe if it is the only version available.This is a asynchronous call by default. Caller can call listModels to confirm model is unregistered
// Unregister the default version of a model from TorchServe if it is the only version available. This is an asynchronous call by default. Caller can call listModels to confirm model is unregistered.
rpc UnregisterModel(UnregisterModelRequest) returns (ManagementResponse) {}
}
}
6 changes: 3 additions & 3 deletions frontend/server/src/test/resources/management_open_api.json
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@
}
},
"put": {
"description": "Configure number of workers for a default version of a model.This is a asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.",
"description": "Configure number of workers for a default version of a model. This is an asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.",
"operationId": "setAutoScale",
"parameters": [
{
Expand Down Expand Up @@ -877,7 +877,7 @@
}
},
"delete": {
"description": "Unregister the default version of a model from TorchServe if it is the only version available.This is a asynchronous call by default. Caller can call listModels to confirm model is unregistered",
"description": "Unregister the default version of a model from TorchServe if it is the only version available. This is an asynchronous call by default. Caller can call listModels to confirm model is unregistered.",
"operationId": "unregisterModel",
"parameters": [
{
Expand Down Expand Up @@ -1254,7 +1254,7 @@
}
},
"put": {
"description": "Configure number of workers for a specified version of a model. This is a asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.",
"description": "Configure number of workers for a specified version of a model. This is an asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.",
"operationId": "version_setAutoScale",
"parameters": [
{
Expand Down
6 changes: 3 additions & 3 deletions frontend/server/src/test/resources/model_management_api.json
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
}
},
"put": {
"description": "Configure number of workers for a default version of a model.This is a asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.",
"description": "Configure number of workers for a default version of a model. This is an asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.",
"operationId": "setAutoScale",
"parameters": [
{
Expand Down Expand Up @@ -422,7 +422,7 @@
}
},
"delete": {
"description": "Unregister the default version of a model from TorchServe if it is the only version available.This is a asynchronous call by default. Caller can call listModels to confirm model is unregistered",
"description": "Unregister the default version of a model from TorchServe if it is the only version available. This is an asynchronous call by default. Caller can call listModels to confirm model is unregistered.",
"operationId": "unregisterModel",
"parameters": [
{
Expand Down Expand Up @@ -799,7 +799,7 @@
}
},
"put": {
"description": "Configure number of workers for a specified version of a model. This is a asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.",
"description": "Configure number of workers for a specified version of a model. This is an asynchronous call by default. Caller need to call describeModel to check if the model workers has been changed.",
"operationId": "version_setAutoScale",
"parameters": [
{
Expand Down

0 comments on commit 06d2d57

Please sign in to comment.