Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isinstance_af #1664

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add isinstance_af #1664

wants to merge 2 commits into from

Conversation

sdaulton
Copy link
Contributor

@sdaulton sdaulton commented Feb 8, 2023

Summary: Creates a new helper method for checking both if a given AF is an instance of a class or if the given AF wraps a base AF that is an instance of a class

Differential Revision: D43127722

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Feb 8, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43127722

@codecov
Copy link

codecov bot commented Feb 8, 2023 •
edited
Loading

Codecov Report

Merging #1664 (a10d9f2) into main (63dd0cd) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a10d9f2 differs from pull request most recent head e147346. Consider uploading reports for the commit e147346 to get more accurate results

@@            Coverage Diff            @@
##              main     #1664   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          169       170    +1     
  Lines        14518     14531   +13     
=========================================
+ Hits         14518     14531   +13
Impacted Files Coverage Δ
botorch/acquisition/fixed_feature.py 100.00% <100.00%> (ø)
botorch/acquisition/penalized.py 100.00% <100.00%> (ø)
botorch/acquisition/proximal.py 100.00% <100.00%> (ø)
botorch/acquisition/utils.py 100.00% <100.00%> (ø)
botorch/acquisition/wrapper.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sdaulton and others added 2 commits February 14, 2023 16:31
@sdaulton @facebook-github-bot
acquisition function wrapper (pytorch#1532)
760b499 
Summary:
Pull Request resolved: pytorch#1532

Add a wrapper for modifying inputs/outputs. This is useful for not only probabilistic reparameterization, but will also simplify other integrated AFs (e.g. MCMC) as well as fixed feature AFs and things like prior-guided AFs

Differential Revision: https://internalfb.com/D41629186

fbshipit-source-id: 181450760c829d5e6b9309f7ee1d07428699b02a
@sdaulton @facebook-github-bot
Add isinstance_af (pytorch#1664)
e147346 
Summary:
Pull Request resolved: pytorch#1664

Creates a new helper method for checking both if a given AF is an instance of a class or if the given AF wraps a base AF that is an instance of a class

Differential Revision: D43127722

fbshipit-source-id: e46a289a1e1fe815ded61bc271e62d21563eb1c7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43127722

@facebook-github-bot
Copy link
Contributor

Hi @sdaulton!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdaulton @facebook-github-bot