-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Codemod][PSS] Upgrade fbcode/pytorch to Python Scientific Stack 2 #3845
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3845
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 12 Unrelated FailuresAs of commit 32abc8d with merge base 79047bf (): NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D64008689 |
Summary: Pull Request resolved: pytorch/audio#3845 Differential Revision: D64008689
Summary: X-link: pytorch/captum#1387 X-link: pytorch/botorch#2584 X-link: pytorch/audio#3845 Differential Revision: D64008689
Summary: X-link: pytorch/captum#1387 X-link: pytorch/botorch#2584 X-link: pytorch/audio#3845 Differential Revision: D64008689
Summary: X-link: pytorch/opacus#680 X-link: pytorch/botorch#2584 X-link: pytorch/audio#3845 Differential Revision: D64008689
Summary: X-link: pytorch/opacus#680 X-link: pytorch/captum#1387 X-link: pytorch/audio#3845 Differential Revision: D64008689
…ytorch#3845) Summary: X-link: pytorch/opacus#680 X-link: pytorch/captum#1387 X-link: pytorch/botorch#2584 Differential Revision: D64008689
198bdff
to
32abc8d
Compare
This pull request was exported from Phabricator. Differential Revision: D64008689 |
…ch#3845) Summary: X-link: pytorch/opacus#680 X-link: pytorch/captum#1387 X-link: pytorch/botorch#2584 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
Summary: X-link: pytorch/audio#3846 X-link: pytorch/opacus#680 X-link: pytorch/captum#1387 X-link: pytorch/audio#3845 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
Summary: X-link: pytorch/audio#3846 X-link: pytorch/opacus#680 X-link: pytorch/botorch#2584 X-link: pytorch/audio#3845 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
Summary: X-link: pytorch/captum#1389 X-link: pytorch/botorch#2586 X-link: pytorch/audio#3846 X-link: pytorch/captum#1387 X-link: pytorch/botorch#2584 X-link: pytorch/audio#3845 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
Differential Revision: D64619891 Pull Request resolved: #3846
Differential Revision: D64008689