Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI linux_job permissions #1576

Merged
merged 3 commits into from
Jan 18, 2025
Merged

Fix CI linux_job permissions #1576

merged 3 commits into from
Jan 18, 2025

Conversation

jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Jan 17, 2025

Fix failing CI jobs. Adding explicit permissions for infra job -> linux_job_v2

Copy link

pytorch-bot bot commented Jan 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1576

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 08bccdc with merge base 1240b19 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
@jainapurva jainapurva added ci topic: not user facing Use this tag if you don't want this PR to show up in release notes labels Jan 17, 2025
@jainapurva jainapurva marked this pull request as ready for review January 17, 2025 02:05
@jerryzh168
Copy link
Contributor

for the test failure, I think we need to add a skip for gpu_9_0, similar to

@unittest.skipIf(
not is_sm_at_least_89(), "Requires GPU with compute capability >= 8.9"
)
for this test:
def test_autoquant_float8(self, device, dtype):

somehow it didn't show up in the CI in my PR

@jainapurva jainapurva force-pushed the fix_ci branch 2 times, most recently from da7ecd4 to a219d87 Compare January 17, 2025 22:18
@jainapurva jainapurva merged commit 32d9b0b into main Jan 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants