-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: misc best practices #70
Conversation
Let's not reformat test fixtures. They are not always even correct Python. |
b369365
to
9a084f1
Compare
None of the proposed changes in this PR touch the test suite. I've separated them from the other PRs, so can be reviewed independently. All fairly minor if you see the changes in isolation (per commit). |
Thanks! |
@kit1980 could we please enable "Rebase and merge" in the settings? Squash is a good default, but in this case the commits are atomic, and it is helpful to keep them in case one type of changes need to be reverted/blamed (e.g. mypy). Both keep linear history. |
done |
Thanks! |
Split each refactor per commit for easier review:
assert
where possibleargs.path
is already a required argument and validated by argparse, removednot args.path
which is never reachedI'll rebase/group the commits and fix test when the other PRs are merged. I've got more functional changes lined up, but will hold off until you've had time to review/merge the outstanding PRs to avoid conflicts.