add torchfix --version #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes the default command to not require an argument and to default to your current working directory Signed-off-by: Eli Uriegas <[email protected]>
facebook-github-bot
added
the
CLA Signed
kit1980
reviewed
Jan 27, 2024
| @@ -14,7 +14,8 @@ def main() -> None: | |||
|
|
|||
| parser.add_argument( | |||
| "path", | |||
| nargs="+", | |||
| nargs="*", | |||
There was a problem hiding this comment.
The current behavior is intentional to mimic ruff's API.
There was a problem hiding this comment.
torchfix --version won't work otherwise since the invocation will have to look like torchfix --version .
There was a problem hiding this comment.
For context this is what this looks like if you don't change that:
❯ torchfix --version
usage: torchfix [-h] [--fix] [-j JOBS] [--select {ALL}] [--version] [--show-stderr] path [path ...]
torchfix: error: the following arguments are required: path
There was a problem hiding this comment.
Maybe it's a bigger change, but torchfix --version should work, and just torchfix should print help.
There was a problem hiding this comment.
I think nargs is fine, but without default?
Signed-off-by: Eli Uriegas <[email protected]>
kit1980
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes the default command to not require an argument and to default to your current working directory
Fixes #13