Skip to content

Commit

Permalink
Update README.md to include info on all TOR0 rules (#10)
Browse files Browse the repository at this point in the history
* Update README.md to include info on all TOR0 rules

* Address review comments
  • Loading branch information
kit1980 authored Jan 18, 2024
1 parent 3e15bd9 commit f4689df
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,18 @@ To get the LU factorization see `torch.lu`, which can be used with `torch.lu_sol

`X = torch.solve(B, A).solution` should be replaced with `X = torch.linalg.solve(A, B)`.

### TOR002 Likely typo `require_grad` in assignment. Did you mean `requires_grad`?

This is a common misspelling that can lead to silent performance issues.

### TOR003 Please pass `use_reentrant` explicitly to `checkpoint`

The default value of the `use_reentrant` parameter in `torch.utils.checkpoint` is being changed
from `True` to `False`. In the meantime, the value needs to be passed explicitly.

See this [forum post](https://dev-discuss.pytorch.org/t/bc-breaking-update-to-torch-utils-checkpoint-not-passing-in-use-reentrant-flag-will-raise-an-error/1745)
for details.

### TOR101 Use of deprecated function

#### torch.nn.utils.weight_norm
Expand Down

0 comments on commit f4689df

Please sign in to comment.