Skip to content

Commit

Permalink
CI: enable testing on macOS (#75)
Browse files Browse the repository at this point in the history
When I run `torchfix` on macOS the `contextlib.redirect_stderr` works as
expected.

However, in the code we make an exception for `Darwin` (macOS):


https://github.com/pytorch-labs/torchfix/blob/main/torchfix/__main__.py#L25

By enabling this test in CI we could test if removal of the dup2
workaround is possible.
  • Loading branch information
sbrugman authored Sep 9, 2024
1 parent 458d6ab commit 311cdd7
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion .github/workflows/test-torchfix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,16 @@ on:

jobs:
test-torchfix:
runs-on: ubuntu-latest
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.10'
- name: Upgrade build dependencies
run: |
pip3 install -U pip
Expand Down

0 comments on commit 311cdd7

Please sign in to comment.