SpecDB: Add OutTensor specs for add.Tensor & add.Scalar #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59402158 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D59402158 |
manuelcandales
force-pushed
the
export-D59402158
branch
from
5fb625d to
279ad5c
Compare
manuelcandales
added a commit
to manuelcandales/FACTO-1
that referenced
this pull request
Jul 5, 2024
Summary: Pull Request resolved: pytorch-labs#5 Added the out tensor spec for: - add.Tensor: promoted type of inputs must be castable to out dtype - add.Scalar: promoted type of inputs must be equal to out dtype Reviewed By: zonglinpengmeta Differential Revision: D59402158
|
This pull request was exported from Phabricator. Differential Revision: D59402158 |
manuelcandales
force-pushed
the
export-D59402158
branch
from
279ad5c to
f7e281f
Compare
Summary: Pull Request resolved: pytorch-labs#5 Added the out tensor spec for: - add.Tensor: promoted type of inputs must be castable to out dtype - add.Scalar: promoted type of inputs must be equal to out dtype Prompted by Jarvis's adoption of FACTO-based testing on D59247125 Reviewed By: zonglinpengmeta Differential Revision: D59402158
|
This pull request was exported from Phabricator. Differential Revision: D59402158 |
manuelcandales
force-pushed
the
export-D59402158
branch
from
f7e281f to
de23a03
Compare
manuelcandales
added a commit
to manuelcandales/FACTO-1
that referenced
this pull request
Jul 5, 2024
Summary: Pull Request resolved: pytorch-labs#5 Added the out tensor spec for: - add.Tensor: promoted type of inputs must be castable to out dtype - add.Scalar: promoted type of inputs must be equal to out dtype Prompted by Jarvis's adoption of FACTO-based testing on D59247125 Reviewed By: zonglinpengmeta Differential Revision: D59402158
|
This pull request has been merged in 7c5c7c7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D59402158