gh-128446: Skip Windows CI for configure/Makefile changes #128450
Conversation
erlend-aasland
added
skip news
needs backport to 3.12
|
Looks good. Can you add a bogus to-be-reverted-before-merge change to the *nix build system and verify that the Windows CI does not run? |
srinivasreddy
requested review from
erlend-aasland and
corona10
as code owners
Modified the logic to use two conditions: First check if there ARE configure/Makefile files (grep -qE) Then check if there are NO other files (! grep -qvE) Only skip Windows CI when BOTH conditions are true (only configure-related files changed) This way, Windows CI will be skipped only when ALL changed files are configure/Makefile related, and will run if there are any other changes
|
Let's put this into draft while you test out the change. Mark it as ready for review when you've got it working. |
|
Please check here, Windows build is skipped https://github.com/python/cpython/actions/runs/12633496189?pr=128450
|
|
The changes that are required to skip the windows build are reverted from here e3c15ca |
|
@erlend-aasland done 👍 |
| @@ -111,6 +116,18 @@ jobs: | |||
| echo "Branch too old for CIFuzz tests; or no C files were changed" | |||
| echo "run-cifuzz=false" >> "$GITHUB_OUTPUT" | |||
| fi | |||
|
|
|||
| CHANGED_FILES=$(git diff --name-only "origin/$GITHUB_BASE_REF..") | |||
There was a problem hiding this comment.
I pushed this branch to my fork's main and it failed:
main
Run hypothesis tests
Branch too old for CIFuzz tests; or no C files were changed
fatal: ambiguous argument 'origin/..': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Error: Process completed with exit code 128.
https://github.com/hugovk/cpython/actions/runs/12670020811/job/35308768214
Here's an older push that passed:
main
Run hypothesis tests
Branch too old for CIFuzz tests; or no C files were changed
https://github.com/hugovk/cpython/actions/runs/12382188860/job/34562372543
I think you need to check if [ "$GITHUB_BASE_REF" = "main" ] before doing this git diff. Compare the previous block.
There was a problem hiding this comment.
Done in d1f1d61
|
Hmm, one thing I noticed, if I want to run the CI on my branch in my fork before opening a PR (for example, by prefixing the branch with 
https://github.com/hugovk/cpython/actions/runs/12698006947 I would much prefer to still be able to test Windows on the CI on my fork because I develop on macOS and often things are different on Windows, and I'd like to make sure they're working before opening a PR. Can we retain this behaviour? |
|
This also skips Windows because a push to a fork isn't a PR: https://github.com/hugovk/cpython/actions/runs/13012655642 |
|
I think it is a good idea to change the default to |
… contains only changes to Configure or Makefile files
configure/Makefilechanges #128446