Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128227: Regenerate requirements file #128228

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

wrongnull
Copy link
Contributor

@wrongnull wrongnull commented Dec 24, 2024

@picnixz
Copy link
Contributor

picnixz commented Dec 24, 2024

The make venv step seemed to have failed (due to setuptools version). Maybe the CI job should also be updated?

@Eclips4 Eclips4 added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Dec 24, 2024
@Eclips4
Copy link
Member

Eclips4 commented Dec 24, 2024

The make venv step seemed to have failed (due to setuptools version). Maybe the CI job should also be updated?

I'm sure this failed due to a non-clean venv. Now CI passes.

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@Eclips4 Eclips4 merged commit 7985d46 into python:main Dec 24, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @wrongnull for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 24, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 24, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 24, 2024

GH-128229 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 24, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 24, 2024

GH-128230 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 24, 2024
Eclips4 pushed a commit that referenced this pull request Dec 24, 2024
…-128228) (#128229)

gh-128227: Regenerate `Doc/requirements-oldest-sphinx.txt` (GH-128228)
(cherry picked from commit 7985d46)

Co-authored-by: Bogdan Romanyuk <[email protected]>
Eclips4 pushed a commit that referenced this pull request Dec 24, 2024
…-128228) (#128230)

gh-128227: Regenerate `Doc/requirements-oldest-sphinx.txt` (GH-128228)
(cherry picked from commit 7985d46)

Co-authored-by: Bogdan Romanyuk <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants