Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126664: revert: Use else instead of finally in docs explaining "with" #128169

Merged

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Dec 22, 2024

… statement" documentation. (pythonGH-126665)"

This reverts commit 25257d6.
@gpshead gpshead added docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Dec 22, 2024
@gpshead gpshead self-assigned this Dec 22, 2024
@gpshead gpshead requested a review from willingc as a code owner December 22, 2024 09:43
@gpshead gpshead enabled auto-merge (squash) December 22, 2024 09:44
@gpshead gpshead merged commit 228f275 into python:main Dec 22, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 22, 2024
…aining "with" (pythonGH-128169)

Revert "pythongh-126664: Use `else` instead of `finally` in "The with statement" documentation. (pythonGH-126665)"

This reverts commit 25257d6.
(cherry picked from commit 228f275)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 22, 2024
…aining "with" (pythonGH-128169)

Revert "pythongh-126664: Use `else` instead of `finally` in "The with statement" documentation. (pythonGH-126665)"

This reverts commit 25257d6.
(cherry picked from commit 228f275)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 22, 2024

GH-128170 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 22, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 22, 2024

GH-128171 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 22, 2024
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Dec 23, 2024
…aining "with" (python#128169)

Revert "pythongh-126664: Use `else` instead of `finally` in "The with statement" documentation. (pythonGH-126665)"

This reverts commit 25257d6.
gpshead added a commit that referenced this pull request Dec 24, 2024
…laining "with" (GH-128169) (#128170)

gh-126664: revert: Use `else` instead of `finally` in docs explaining "with" (GH-128169)

Revert "gh-126664: Use `else` instead of `finally` in "The with statement" documentation. (GH-126665)"

This reverts commit 25257d6.
(cherry picked from commit 228f275)

Co-authored-by: Gregory P. Smith <[email protected]>
gpshead added a commit that referenced this pull request Dec 24, 2024
…laining "with" (GH-128169) (#128171)

gh-126664: revert: Use `else` instead of `finally` in docs explaining "with" (GH-128169)

Revert "gh-126664: Use `else` instead of `finally` in "The with statement" documentation. (GH-126665)"

This reverts commit 25257d6.
(cherry picked from commit 228f275)

Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant